diff options
| author | Linmao Li <lilinmao@kylinos.cn> | 2026-07-20 16:44:26 +0800 |
|---|---|---|
| committer | Maíra Canal <mcanal@igalia.com> | 2026-07-23 20:07:23 -0300 |
| commit | 6273dd3ffb54ec581855b82ae77331b66028249c (patch) | |
| tree | 8b9234294c14a454af2c887fa70bc8bfe55a25c6 | |
| parent | b04a248cfa6cfa1e7dc9ce91cb1eb88b1a70dd69 (diff) | |
| download | linux-6273dd3ffb54ec581855b82ae77331b66028249c.tar.gz linux-6273dd3ffb54ec581855b82ae77331b66028249c.tar.bz2 linux-6273dd3ffb54ec581855b82ae77331b66028249c.zip | |
drm/vc4: Shut down BO cache timer before teardown
The BO cache timer callback schedules time_work, and time_work can rearm
the timer through vc4_bo_cache_free_old().
vc4_bo_cache_destroy() deletes the timer and then cancels the work, which
does not break that cycle: the work being cancelled can rearm the timer,
and the timer then queues work again after teardown.
Use timer_shutdown_sync() instead, so the timer cannot be rearmed and the
cycle ends with cancel_work_sync().
Fixes: c826a6e10644 ("drm/vc4: Add a BO cache.")
Cc: stable@vger.kernel.org
Signed-off-by: Linmao Li <lilinmao@kylinos.cn>
Link: https://patch.msgid.link/20260720084426.1632508-1-lilinmao@kylinos.cn
Reviewed-by: Maíra Canal <mcanal@igalia.com>
Signed-off-by: Maíra Canal <mcanal@igalia.com>
| -rw-r--r-- | drivers/gpu/drm/vc4/vc4_bo.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c index 5e7c46dd7823..49ea2ed0996b 100644 --- a/drivers/gpu/drm/vc4/vc4_bo.c +++ b/drivers/gpu/drm/vc4/vc4_bo.c @@ -1048,7 +1048,7 @@ static void vc4_bo_cache_destroy(struct drm_device *dev, void *unused) struct vc4_dev *vc4 = to_vc4_dev(dev); int i; - timer_delete(&vc4->bo_cache.time_timer); + timer_shutdown_sync(&vc4->bo_cache.time_timer); cancel_work_sync(&vc4->bo_cache.time_work); vc4_bo_cache_purge(dev); |